linux-kernel - Re: [PATCH] selftest: vm: remove orphaned references to local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAa6QmRy3N9cO14AVz2g0dA_MOSatwzufQxO1PwH35J4mYPbmQ@mail.gmail.com>
Date:   Wed, 31 Aug 2022 14:24:34 -0700
From:   "Zach O'Keefe" <zokeefe@...gle.com>
To:     Axel Rasmussen <axelrasmussen@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>,
        Tarun Sahu <tsahu@...ux.ibm.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftest: vm: remove orphaned references to local_config.{h,mk}

On Wed, Aug 31, 2022 at 2:16 PM Axel Rasmussen <axelrasmussen@...gle.com> wrote:
>
> Note: this commit is intended to apply to mm-unstable, the commit being
> fixed only exists in that branch for now.
>
> Commit b4efb234e53cc60ccdc855190be9f35918687412 ("Kselftests: remove
> support of libhugetlbfs from kselftests") removed the rule describing
> how to build local_config.{h,mk}, but it left two references to these
> files lingering around. The result is, none of the selftests could be
> built due to dependencies with no rule for how to build them.
>
> Signed-off-by: Axel Rasmussen <axelrasmussen@...gle.com>
> ---
>  tools/testing/selftests/vm/Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index b52f2cc51482..4ae879f70f4c 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,9 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Makefile for vm selftests
>
> -LOCAL_HDRS += $(selfdir)/vm/local_config.h $(top_srcdir)/mm/gup_test.h
> -
> -include local_config.mk
> +LOCAL_HDRS += $(top_srcdir)/mm/gup_test.h
>
>  uname_M := $(shell uname -m 2>/dev/null || echo not)
>  MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's/ppc64.*/ppc64/')
> --
> 2.37.2.789.g6183377224-goog
>

Thanks Axel! Works here on latest mm-unstable

Tested-by: Zach O'Keefe <zokeefe@...gle.com>