[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YxGTXK452NwcQEGC@kroah.com>
Date: Fri, 2 Sep 2022 07:23:40 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] tty: serial: introduce transmit helper generators
On Fri, Sep 02, 2022 at 07:16:58AM +0200, Jiri Slaby wrote:
> On 01. 09. 22, 14:25, Greg KH wrote:
> > Much nicer, but:
> >
> > > +#define __DEFINE_UART_PORT_TX_HELPER(name, port, ch, tx_ready, put_char, \
> > > + tx_done, for_test, for_post, ...) \
> >
> > Do you really need "port" and "ch" as part of this macro? You always
> > set that to the same thing in your patches, so is it really needed?
>
> Not really, just to make obvious that those are the names that can be used
> in tx_ready, put_char... I can remove it, if you prefer, of course.
I'd recommend just removing it as it's a hard macro to read as-is. That
would make it a bit more simple as then you are just passing in the name
and the callback functions, which makes a bit more sense to me.
thanks,
greg k-h
Powered by blists - more mailing lists