linux-kernel - Re: [PATCH next-next 0/2] net: vlan: two small refactors to make code more concise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74d89f90-c717-2a72-b16b-812c1af1d6d2@huawei.com>
Date:   Fri, 2 Sep 2022 09:12:20 +0800
From:   "Ziyang Xuan (William)" <william.xuanziyang@...wei.com>
To:     Paolo Abeni <pabeni@...hat.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <morbo@...gle.com>,
        <netdev@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next-next 0/2] net: vlan: two small refactors to make code
 more concise



在 2022/9/1 21:28, Paolo Abeni 写道:
> Hello,
> 
> On Wed, 2022-08-31 at 12:09 +0800, Ziyang Xuan wrote:
>> Give two small refactors to make code more concise.
>>
>> Ziyang Xuan (2):
>>   net: vlan: remove unnecessary err variable in vlan_init_net()
>>   net: vlan: reduce indentation level in __vlan_find_dev_deep_rcu()
>>
>>  net/8021q/vlan.c      |  5 +----
>>  net/8021q/vlan_core.c | 22 +++++++++-------------
>>  2 files changed, 10 insertions(+), 17 deletions(-)
> 
> The patches look correct to me, but I think is better to defer this
> kind of nun-functional refactors to some work actually doing new stuff,
> to avoid unneeded noise.
> 
> Note that I merged a few other clean-up recently, but e.g. they at
> least formally removed some unneeded branch.
> 
> Sorry, I'm not going to apply this series.

No problem, I will try to dig deeper.

> 
> Cheers,
> 
> Paolo
> 
> .
>