linux-kernel - Re: [PATCH v1] drivers/base/auxiliary: check return value of strrchr()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxL1TprLv3wzr08u@kroah.com>
Date:   Sat, 3 Sep 2022 08:33:50 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Li Zhong <floridsleeves@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        rafael@...nel.org
Subject: Re: [PATCH v1] drivers/base/auxiliary: check return value of
 strrchr()

On Fri, Sep 02, 2022 at 11:25:31PM -0700, Li Zhong wrote:
> From: Li Zhong <floridsleeves@...il.com>
> 
> The return value of strrchr() could be NULL, which will cause invalid
> offset in (int)(p - name). So we check it here.
> 
> Signed-off-by: Li Zhong <floridsleeves@...il.com>
> ---
>  drivers/base/auxiliary.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 8c5e65930617..7ac23be47e1f 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev,
> struct kobj_uevent_env *env)
> 
>   name = dev_name(dev);
>   p = strrchr(name, '.');
> -
> + if (!p)
> + return -EINVAL;
>   return add_uevent_var(env, "MODALIAS=%s%.*s", AUXILIARY_MODULE_PREFIX,
>         (int)(p - name), name);
>  }
> -- 
> 2.25.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot