linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: add k3-j721e-beagleboneai64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c6a9a5f-b3a9-8e63-a6d8-ed6d70cf09c7@ti.com>
Date:   Sat, 3 Sep 2022 12:03:13 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Robert Nelson <robertcnelson@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
CC:     Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Jason Kridner <jkridner@...gleboard.org>,
        Drew Fustini <drew@...gleboard.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: add k3-j721e-beagleboneai64

Hi,

On 23/08/22 4:33 am, Robert Nelson wrote:
> +	main_i2c2_pins_default: main_i2c2_pins_default {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x208, PIN_INPUT_PULLUP, 4) /* (W5) MCAN0_RX.I2C2_SCL */
> +			J721E_IOPAD(0x20c, PIN_INPUT_PULLUP, 4) /* (W6) MCAN0_TX.I2C2_SDA */
> +			J721E_IOPAD(0x138, PIN_INPUT, 7) /* (AE25) PRG0_PRU1_GPO14.GPIO0_77 */
> +			J721E_IOPAD(0x13c, PIN_INPUT, 7) /* (AF29) PRG0_PRU1_GPO15.GPIO0_78 */
> +		>;
> +	};
> +
> +	main_i2c3_pins_default: main-i2c3-pins-default {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x270, PIN_INPUT_PULLUP, 4) /* (T26) MMC2_CLK.I2C3_SCL */
> +			J721E_IOPAD(0x274, PIN_INPUT_PULLUP, 4) /* (T25) MMC2_CMD.I2C3_SDA */
> +		>;
> +	};
> +
> +	main_i2c4_pins_default: main_i2c4_pins_default {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x1e0, PIN_INPUT_PULLUP, 2) /* (Y5) SPI1_D0.I2C4_SCL */
> +			J721E_IOPAD(0x1dc, PIN_INPUT_PULLUP, 2) /* (Y1) SPI1_CLK.I2C4_SDA */
> +			J721E_IOPAD(0x30, PIN_INPUT, 7) /* (AF24) PRG1_PRU0_GPO11.GPIO0_12 */
> +			J721E_IOPAD(0x34, PIN_INPUT, 7) /* (AJ24) PRG1_PRU0_GPO12.GPIO0_13 */
> +		>;
> +	};
> +
> +	main_i2c5_pins_default: main-i2c5-pins-default {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x150, PIN_INPUT_PULLUP, 2) /* (Y26) PRG0_MDIO0_MDIO.I2C5_SCL */
> +			J721E_IOPAD(0x154, PIN_INPUT_PULLUP, 2) /* (AA27) PRG0_MDIO0_MDC.I2C5_SDA */
> +		>;
> +	};
> +
> +	main_i2c6_pins_default: main_i2c6_pins_default {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x1d0, PIN_INPUT_PULLUP, 2) /* (AA3) SPI0_D1.I2C6_SCL */
> +			J721E_IOPAD(0x1e4, PIN_INPUT_PULLUP, 2) /* (Y2) SPI1_D1.I2C6_SDA */
> +			J721E_IOPAD(0x74, PIN_INPUT, 7) /* (AC21) PRG1_PRU1_GPO7.GPIO0_28 */
> +			J721E_IOPAD(0xa4, PIN_INPUT, 7) /* (AH22) PRG1_PRU1_GPO19.GPIO0_40 */
> +		>;
> +	};
> +

Please address following warnings with make dtbs W=12

+arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts: /bus@...000/pinctrl@...000/main_i2c2_pins_default: Character '_' not recommended in node name
+arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts: /bus@...000/pinctrl@...000/main_i2c4_pins_default: Character '_' not recommended in node name
+arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts: /bus@...000/pinctrl@...000/main_i2c6_pins_default: Character '_' not recommended in node name