linux-kernel - Re: [PATCH v2 2/3] fortify: Add KUnit test for FORTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSm76QgfbwZ63cSb58=K5EqK+MuLs=-siwUgg7JMNFkQ2g@mail.gmail.com>
Date:   Sat, 3 Sep 2022 14:45:20 +0800
From:   David Gow <davidgow@...gle.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Tom Rix <trix@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        Yury Norov <yury.norov@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Sander Vanheule <sander@...nheule.net>,
        linux-hardening@...r.kernel.org, llvm@...ts.linux.dev,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Isabella Basso <isabbasso@...eup.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Eric Biggers <ebiggers@...gle.com>,
        Hannes Reinecke <hare@...e.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] fortify: Add KUnit test for FORTIFY_SOURCE internals

On Sat, Sep 3, 2022 at 1:17 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Sat, Sep 03, 2022 at 10:59:24AM +0800, David Gow wrote:
> > On Sat, Sep 3, 2022 at 4:43 AM Kees Cook <keescook@...omium.org> wrote:
> > >
> > > Add lib/fortify_kunit.c KUnit test for checking the expected behavioral
> > > characteristics of FORTIFY_SOURCE internals.
> > > [...]
> >
> > Overall, this looks good. It's a bit of a shame FORTIFY_SOURCE doesn't
> > work under UML, but I tested it on everything else I had to hand and
> > it looked good.
>
> It looks like this was never picked up:
> https://lore.kernel.org/lkml/20220210003224.773957-1-keescook@chromium.org/

Ah: I'd forgotten about that. Can confirm this test works under UML
with that patch applied.

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)