linux-kernel - Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a2d493f-d4af-0880-d593-50120cfd3328@sholland.org>
Date:   Sat, 3 Sep 2022 08:38:36 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Peter Geis <pgwipeout@...il.com>, Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     Markus Reichl <m.reichl@...etechno.de>,
        Michael Riesch <michael.riesch@...fvision.net>,
        linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

On 9/2/22 1:45 PM, Peter Geis wrote:
> The otg sync state patch reuses the ret variable, but fails to set it to
> zero after use. This leads to a situation when the otg port is in
> peripheral mode where the otg phy aborts halfway through setup.  It also
> fails to account for a failure to register the extcon notifier. Fix this
> by using our own variable and skipping otg sync in case of failure.
> 
> Fixes: 8dc60f8da22f ("phy: rockchip-inno-usb2: Sync initial otg state")
> Reported-by: Markus Reichl <m.reichl@...etechno.de>
> Reported-by: Michael Riesch <michael.riesch@...fvision.net>
> Signed-off-by: Peter Geis <pgwipeout@...il.com>
> Tested-by: Michael Riesch <michael.riesch@...fvision.net>
> Tested-by: Markus Reichl <m.reichl@...etechno.de>

Reviewed-by: Samuel Holland <samuel@...lland.org>