linux-kernel - Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxTDBpkllQjf0nIW@matsya>
Date:   Sun, 4 Sep 2022 20:53:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        Samuel Holland <samuel@...lland.org>,
        Markus Reichl <m.reichl@...etechno.de>,
        Michael Riesch <michael.riesch@...fvision.net>,
        linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

On 02-09-22, 14:45, Peter Geis wrote:
> The otg sync state patch reuses the ret variable, but fails to set it to
> zero after use. This leads to a situation when the otg port is in
> peripheral mode where the otg phy aborts halfway through setup.  It also
> fails to account for a failure to register the extcon notifier. Fix this
> by using our own variable and skipping otg sync in case of failure.

Applied, thanks

-- 
~Vinod