linux-kernel - Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2022 00:10:31 +0800
From:   Chen-Yu Tsai <wens@...nel.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Peter Geis <pgwipeout@...il.com>, Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        Samuel Holland <samuel@...lland.org>,
        Markus Reichl <m.reichl@...etechno.de>,
        Michael Riesch <michael.riesch@...fvision.net>,
        linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

On Sun, Sep 4, 2022 at 11:24 PM Vinod Koul <vkoul@...nel.org> wrote:
>
> On 02-09-22, 14:45, Peter Geis wrote:
> > The otg sync state patch reuses the ret variable, but fails to set it to
> > zero after use. This leads to a situation when the otg port is in
> > peripheral mode where the otg phy aborts halfway through setup.  It also
> > fails to account for a failure to register the extcon notifier. Fix this
> > by using our own variable and skipping otg sync in case of failure.
>
> Applied, thanks

This should have been applied for v6.0-rc, not -next.
We now have a v6.0 release that doesn't boot properly on RK3399.

ChenYu