linux-kernel - Re: [PATCH 1/3] riscv: convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Sep 2022 15:39:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     guoren@...nel.org, arnd@...db.de, palmer@...osinc.com,
        tglx@...utronix.de, peterz@...radead.org, luto@...nel.org
Cc:     kbuild-all@...ts.01.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        Guo Ren <guoren@...ux.alibaba.com>,
        Huacai Chen <chenhuacai@...nel.org>
Subject: Re: [PATCH 1/3] riscv: convert to generic entry

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on linus/master v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/guoren-kernel-org/riscv-Add-GENERIC_ENTRY-IRQ_STACKS-support/20220904-003954
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: riscv-rv32_defconfig
compiler: riscv32-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8390e92d0bcc635f457df18c8c1baefc78a94e48
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review guoren-kernel-org/riscv-Add-GENERIC_ENTRY-IRQ_STACKS-support/20220904-003954
        git checkout 8390e92d0bcc635f457df18c8c1baefc78a94e48
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/riscv/kernel/sys_riscv.c:80:17: warning: no previous prototype for 'do_sys_ecall_u' [-Wmissing-prototypes]
      80 | asmlinkage void do_sys_ecall_u(struct pt_regs *regs)
         |                 ^~~~~~~~~~~~~~
   arch/riscv/kernel/sys_riscv.c: In function 'do_sys_ecall_u':
>> arch/riscv/kernel/sys_riscv.c:83:39: error: 'SR_UXL' undeclared (first use in this function); did you mean 'SR_XS'?
      83 |         ulong sr_uxl = regs->status & SR_UXL;
         |                                       ^~~~~~
         |                                       SR_XS
   arch/riscv/kernel/sys_riscv.c:83:39: note: each undeclared identifier is reported only once for each function it appears in
>> arch/riscv/kernel/sys_riscv.c:91:23: error: 'SR_UXL_32' undeclared (first use in this function)
      91 |         if (sr_uxl == SR_UXL_32)
         |                       ^~~~~~~~~


vim +83 arch/riscv/kernel/sys_riscv.c

    79	
    80	asmlinkage void do_sys_ecall_u(struct pt_regs *regs)
    81	{
    82		syscall_t syscall;
  > 83		ulong sr_uxl = regs->status & SR_UXL;
    84		ulong nr = regs->a7;
    85	
    86		regs->epc += 4;
    87		regs->orig_a0 = regs->a0;
    88		regs->a0 = -ENOSYS;
    89	
    90		nr = syscall_enter_from_user_mode(regs, nr);
  > 91		if (sr_uxl == SR_UXL_32)

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (112448 bytes)