linux-kernel - [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220905224408.346425-1-francesco.dolcini@toradex.com>
Date:   Tue,  6 Sep 2022 00:44:08 +0200
From:   Francesco Dolcini <francesco.dolcini@...adex.com>
To:     linux-gpio@...r.kernel.org
CC:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Dong Aisheng <aisheng.dong@....com>,
        Fabio Estevam <festevam@...il.com>,
        Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Peng Fan <peng.fan@....com>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        kernel test robot <lkp@...el.com>
Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile

PINCTRL_IMX depends on OF, however the dependency is missed when selected
by PINCTRL_IMX8M* (it does not follow the indirect 'select' statements),
select it explicitly.

Cc: Arnd Bergmann <arnd@...db.de>
Cc: Linus Walleij <linus.walleij@...aro.org>
Reported-by: kernel test robot <lkp@...el.com>
Link: https://lore.kernel.org/all/202209050605.fezJUgFH-lkp@intel.com/
Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
---
Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
---
 drivers/pinctrl/freescale/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index 365fcff8e470..7a32f77792d9 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
 
 config PINCTRL_IMX8MM
 	tristate "IMX8MM pinctrl driver"
+	depends on OF
 	depends on SOC_IMX8M
 	select PINCTRL_IMX
 	help
@@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
 
 config PINCTRL_IMX8MN
 	tristate "IMX8MN pinctrl driver"
+	depends on OF
 	depends on SOC_IMX8M
 	select PINCTRL_IMX
 	help
@@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
 
 config PINCTRL_IMX8MP
 	tristate "IMX8MP pinctrl driver"
+	depends on OF
 	depends on SOC_IMX8M
 	select PINCTRL_IMX
 	help
@@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
 
 config PINCTRL_IMX8MQ
 	tristate "IMX8MQ pinctrl driver"
+	depends on OF
 	depends on SOC_IMX8M
 	select PINCTRL_IMX
 	help
-- 
2.25.1