linux-kernel - RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8412C5E5640C8119FC5FD742877E9@DB9PR04MB8412.eurprd04.prod.outlook.com>
Date:   Tue, 6 Sep 2022 01:16:30 +0000
From:   Jacky Bai <ping.bai@....com>
To:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
CC:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Fabio Estevam <festevam@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Peng Fan <peng.fan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        kernel test robot <lkp@...el.com>
Subject: RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile

> Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
> 
> PINCTRL_IMX depends on OF, however the dependency is missed when
> selected by PINCTRL_IMX8M* (it does not follow the indirect 'select'
> statements), select it explicitly.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Reported-by: kernel test robot <lkp@...el.com>
...
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>

Reviewed-by: Jacky Bai <ping.bai@....com>

BR

> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
> ---
>  drivers/pinctrl/freescale/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 365fcff8e470..7a32f77792d9 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
> 
>  config PINCTRL_IMX8MM
>  	tristate "IMX8MM pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
> 
>  config PINCTRL_IMX8MN
>  	tristate "IMX8MN pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
> 
>  config PINCTRL_IMX8MP
>  	tristate "IMX8MP pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
> 
>  config PINCTRL_IMX8MQ
>  	tristate "IMX8MQ pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> --
> 2.25.1