linux-kernel - Re: [PATCH] dmaengine: stm32-dmamux: Simplify code and save a few bytes of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxWVrphgXmqmsCH2@matsya>
Date:   Mon, 5 Sep 2022 11:52:38 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dmaengine@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dmaengine: stm32-dmamux: Simplify code and save a few
 bytes of memory

On 30-07-22, 22:07, Christophe JAILLET wrote:
> STM32_DMAMUX_MAX_DMA_REQUESTS is small (i.e. 32) and when the 'dma_inuse'
> bitmap is allocated, there is already a check that 'dma_req' is <= this
> limit.
> 
> So, there is no good reason to dynamically allocate this bitmap. This
> just waste some memory and some cycles.
> 
> Use DECLARE_BITMAP with the maximum bitmap size instead.

Applied, thanks

-- 
~Vinod