linux-kernel - Re: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxWWhov7bjz2J+Ur@matsya>
Date:   Mon, 5 Sep 2022 11:56:14 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc:     michal.simek@...inx.com, m.tretter@...gutronix.de,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        git@....com, Shravya Kumbham <shravya.kumbham@...inx.com>,
        Harini Katakam <harini.katakam@...inx.com>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
 coverity warning

On 24-05-22, 13:19, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham <shravya.kumbham@...inx.com>
> 
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.

Applied, thanks

> 
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@...inx.com>
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
> 
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.

It would be very nice to do this change but users would need to be
updated as well, patches are welcome

-- 
~Vinod