linux-kernel - Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for pmc8280c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3668ec5c-becf-2cac-c647-e20fb2156d8f@linaro.org>
Date:   Mon, 5 Sep 2022 12:35:30 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-msm@...r.kernel.org
Cc:     devicetree@...r.kernel.org, agross@...nel.org,
        bhupesh.linux@...il.com, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for
 pmc8280c_lpg node



On 9/5/22 12:08 PM, Krzysztof Kozlowski wrote:
> On 05/09/2022 08:47, Bhupesh Sharma wrote:
>> Hi Krzysztof,
>>
>> On 9/5/22 12:52 AM, Krzysztof Kozlowski wrote:
>>> On 03/09/2022 11:44, Bhupesh Sharma wrote:
>>>> Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
>>>> dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover
>>>> 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same.
>>>>
>>>> While at it, also remove the unused unit address in the node
>>>> label.
>>>>
>>>> Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
>>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> Cc: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>>>> Cc: Bjorn Andersson <andersson@...nel.org>
>>>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +--
>>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>>>> index ae90b97aecb8..2e5cf55afdd5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>>>> @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@...0 {
>>>>    			#interrupt-cells = <2>;
>>>>    		};
>>>>    
>>>> -		pmc8280c_lpg: lpg@...0 {
>>>> +		pmc8280c_lpg: lpg {
>>>
>>> I wonder why I did not see the errors when testing all DTSes for
>>> https://lore.kernel.org/all/20220828084341.112146-9-krzysztof.kozlowski@linaro.org/
>>
>> I did not see the error while running the 'make dtbs_check' locally, so
>> may be something to improve in 'make dtbs_check' infrastructure there.
>>
>>> Anyway, it cannot be lpg - binding requires "pwm".
>>
>> I think that should be a separate patch. It does not seem related to
>> this change anyways - which fixes eeca7d46217c . I will send a v2 soon.
> 
> You would be changing same line twice and eeca7d46217c is not going to
> be backported, so I am no sure if there is benefit to make two patches.

Ok. v2 sent accordingly 
(https://lore.kernel.org/linux-arm-msm/20220905070240.1634997-1-bhupesh.sharma@linaro.org/)

Please help review.

Thanks.