linux-kernel - Re: [PATCH 1/4] Remove unused variable et in efi_get_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXG03PdCpSQQHvOFFk=_L-JVgy6DYob6ZLFd8WfDdaTnCQ@mail.gmail.com>
Date:   Mon, 5 Sep 2022 12:18:16 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Michel Lespinasse <michel@...pinasse.org>
Cc:     Michael Roth <michael.roth@....com>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Remove unused variable et in efi_get_system_table()

On Wed, 31 Aug 2022 at 03:12, Michel Lespinasse <michel@...pinasse.org> wrote:
>
> This avoids a build warning with CONFIG_EFI enabled.
>
> Fixes: 7c4146e88855 (x86/compressed/acpi: Move EFI detection to helper)

Please use " inside the ()

Also, the commit id looks wrong to me.

> Signed-off-by: Michel Lespinasse <michel@...pinasse.org>
> ---
>  arch/x86/boot/compressed/efi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c
> index 6edd034b0b30..c42ee7874eb9 100644
> --- a/arch/x86/boot/compressed/efi.c
> +++ b/arch/x86/boot/compressed/efi.c
> @@ -59,7 +59,6 @@ unsigned long efi_get_system_table(struct boot_params *bp)
>  {
>         unsigned long sys_tbl_pa;
>         struct efi_info *ei;
> -       enum efi_type et;
>
>         /* Get systab from boot params. */
>         ei = &bp->efi_info;
> --
> 2.20.1
>