linux-kernel - Re: [PATCH 3/4] Remove unused variable ret in efi_get_conf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFVz6t3WOPjJZD_g45kKGXJmEkXHC1Bp=6NFrCUGEXf4g@mail.gmail.com>
Date:   Mon, 5 Sep 2022 12:20:44 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Michel Lespinasse <michel@...pinasse.org>
Cc:     Michael Roth <michael.roth@....com>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Remove unused variable ret in efi_get_conf_table()

On Wed, 31 Aug 2022 at 03:13, Michel Lespinasse <michel@...pinasse.org> wrote:
>
> This avoids a build warning with CONFIG_EFI enabled.
>
> Fixes: 61c14ceda840 (x86/compressed/acpi: Move EFI config table lookup to helper)
> Signed-off-by: Michel Lespinasse <michel@...pinasse.org>

Can you combine this one with 2/4? (and add " inside the () on the fixes line)

> ---
>  arch/x86/boot/compressed/efi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c
> index c42ee7874eb9..6ffd22710ed2 100644
> --- a/arch/x86/boot/compressed/efi.c
> +++ b/arch/x86/boot/compressed/efi.c
> @@ -130,7 +130,6 @@ int efi_get_conf_table(struct boot_params *bp, unsigned long *cfg_tbl_pa,
>  {
>         unsigned long sys_tbl_pa;
>         enum efi_type et;
> -       int ret;
>
>         if (!cfg_tbl_pa || !cfg_tbl_len)
>                 return -EINVAL;
> --
> 2.20.1
>