linux-kernel - Re: [PATCH v2 4/5] riscv: use BIT() marco for cpufeature probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7693745.aoefvbuG5b@diego>
Date:   Mon, 05 Sep 2022 13:23:01 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, Conor.Dooley@...rochip.com
Cc:     guoren@...nel.org, apatel@...tanamicro.com, atishp@...osinc.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] riscv: use BIT() marco for cpufeature probing

Am Montag, 5. September 2022, 13:19:41 CEST schrieb Conor.Dooley@...rochip.com:
> On 05/09/2022 12:10, Heiko Stuebner wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > Using the appropriate BIT macro makes the code better readable.
> > 
> > Suggested-by: Conor Dooley <conor.dooley@...rochip.com>
> > Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> 
> Missing the cover-letter with the changelog?
> At least, I didn't get it in my inbox.

darn git send-email and its automatic selection ;-)

I.e. I _should_ have added you to the hard recipient list for my series
in the first place, but instead git send-email selected you based on
the Suggested-by ... but it looks like these selectoions don't get
applied to the cover-letter ... sorry about that


Heiko


> Either way,
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> > ---
> >   arch/riscv/kernel/cpufeature.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> > index 729f7a218093..08f7445985dc 100644
> > --- a/arch/riscv/kernel/cpufeature.c
> > +++ b/arch/riscv/kernel/cpufeature.c
> > @@ -289,10 +289,10 @@ static u32 __init_or_module cpufeature_probe(unsigned int stage)
> >          u32 cpu_req_feature = 0;
> > 
> >          if (cpufeature_probe_svpbmt(stage))
> > -               cpu_req_feature |= (1U << CPUFEATURE_SVPBMT);
> > +               cpu_req_feature |= BIT(CPUFEATURE_SVPBMT);
> > 
> >          if (cpufeature_probe_zicbom(stage))
> > -               cpu_req_feature |= (1U << CPUFEATURE_ZICBOM);
> > +               cpu_req_feature |= BIT(CPUFEATURE_ZICBOM);
> > 
> >          return cpu_req_feature;
> >   }
> > --
> > 2.35.1
> > 
> 
>