linux-kernel - Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxeQB2jawNwpOB5y@bombadil.infradead.org>
Date:   Tue, 6 Sep 2022 11:23:03 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Wupeng Ma <mawupeng1@...wei.com>
Cc:     akpm@...ux-foundation.org, david@...hat.com, npiggin@...e.de,
        ying.huang@...el.com, hannes@...xchg.org, corbet@....net,
        mgorman@...e.de, keescook@...omium.org, yzaikin@...gle.com,
        songmuchun@...edance.com, mike.kravetz@...cle.com,
        osalvador@...e.de, surenb@...gle.com, rppt@...nel.org,
        charante@...eaurora.org, jsavitz@...hat.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone
 watermark_scale_factor

On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote:
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 205d605cacc5..d16d06c71e5a 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = {
>  		.maxlen		= sizeof(watermark_scale_factor),
>  		.mode		= 0644,
>  		.proc_handler	= watermark_scale_factor_sysctl_handler,
> -		.extra1		= SYSCTL_ONE,
> -		.extra2		= SYSCTL_THREE_THOUSAND,
>  	},
>  	{
>  		.procname	= "percpu_pagelist_high_fraction",

Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while
at it, you can git log the kernel/sysctl.c for prior moves and for
the motivations. No need to keep expanding on the existing table.

  Luis