linux-kernel - Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f54bdd79-b78e-470d-7048-8dee0ee39a1f@huawei.com>
Date:   Wed, 7 Sep 2022 11:29:19 +0800
From:   mawupeng <mawupeng1@...wei.com>
To:     <mcgrof@...nel.org>
CC:     <mawupeng1@...wei.com>, <akpm@...ux-foundation.org>,
        <david@...hat.com>, <npiggin@...e.de>, <ying.huang@...el.com>,
        <hannes@...xchg.org>, <corbet@....net>, <mgorman@...e.de>,
        <keescook@...omium.org>, <yzaikin@...gle.com>,
        <songmuchun@...edance.com>, <mike.kravetz@...cle.com>,
        <osalvador@...e.de>, <surenb@...gle.com>, <rppt@...nel.org>,
        <charante@...eaurora.org>, <jsavitz@...hat.com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <lkp@...el.com>
Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone
 watermark_scale_factor



On 2022/9/7 2:23, Luis Chamberlain wrote:
> On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote:
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 205d605cacc5..d16d06c71e5a 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = {
>>  		.maxlen		= sizeof(watermark_scale_factor),
>>  		.mode		= 0644,
>>  		.proc_handler	= watermark_scale_factor_sysctl_handler,
>> -		.extra1		= SYSCTL_ONE,
>> -		.extra2		= SYSCTL_THREE_THOUSAND,
>>  	},
>>  	{
>>  		.procname	= "percpu_pagelist_high_fraction",
> 
> Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while
> at it, you can git log the kernel/sysctl.c for prior moves and for
> the motivations. No need to keep expanding on the existing table.
> 
>   Luis

Ok.

I will move this sysctl to mm/page_alloc.c next version.