linux-kernel - Re: [PATCH] hid: hid-logitech-hidpp: avoid unnecessary assignments in hidpp_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64a3bd41-1184-e65b-e70f-01ef8daadb53@gmail.com>
Date:   Tue, 6 Sep 2022 15:57:13 +0800
From:   Hangyu Hua <hbh25y@...il.com>
To:     lains@...eup.net, jikos@...nel.org, benjamin.tissoires@...hat.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: hid-logitech-hidpp: avoid unnecessary assignments in
 hidpp_connect_event

On 12/8/2022 10:55, Hangyu Hua wrote:
> hidpp->delayed_input can't be assigned to an object that already call
> input_free_device when input_register_device fails.
> 
> Fixes: c39e3d5fc9dd ("HID: logitech-hidpp: late bind the input device on wireless connection")
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> ---
>   drivers/hid/hid-logitech-hidpp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 68f9e9d207f4..c3602bf8f9b9 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3959,8 +3959,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
>   	hidpp_populate_input(hidpp, input);
>   
>   	ret = input_register_device(input);
> -	if (ret)
> +	if (ret) {
>   		input_free_device(input);
> +		return;
> +	}
>   
>   	hidpp->delayed_input = input;
>   }
Gentel ping.