linux-kernel - Re: linux-next: build failure after merge of the slab tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dab10759-c059-2254-116b-8360bc240e57@suse.cz>
Date:   Tue, 6 Sep 2022 09:53:31 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Cc:     Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Marco Elver <elver@...gle.com>
Subject: Re: linux-next: build failure after merge of the slab tree

On 9/6/22 08:51, Stephen Rothwell wrote:
> Hi all,

Hi,

> After merging the slab tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> kernel/bpf/memalloc.c: In function 'bpf_mem_free':
> kernel/bpf/memalloc.c:613:33: error: implicit declaration of function '__ksize'; did you mean 'ksize'? [-Werror=implicit-function-declaration]
>    613 |         idx = bpf_mem_cache_idx(__ksize(ptr - LLIST_NODE_SZ));
>        |                                 ^~~~~~~
>        |                                 ksize

Could you use ksize() here? I'm guessing you picked __ksize() because 
kasan_unpoison_element() in mm/mempool.c did, but that's to avoid 
kasan_unpoison_range() in ksize() as this caller does it differently.
AFAICS your function doesn't handle kasan differently, so ksize() should 
be fine.

> Caused by commit
> 
>    8dfa9d554061 ("mm/slab_common: move declaration of __ksize() to mm/slab.h")
> 
> interacting with commit
> 
>    7c8199e24fa0 ("bpf: Introduce any context BPF specific memory allocator.")
> 
> from the bpf-next tree.
> 
> I have reverted the slab tree commit for today.
>