linux-kernel - RE: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM6PR12MB3082B9C670B5F58215259A76E8419@DM6PR12MB3082.namprd12.prod.outlook.com>
Date:   Wed, 7 Sep 2022 03:13:12 +0000
From:   "Gupta, Nipun" <Nipun.Gupta@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "jeffrey.l.hugo@...il.com" <jeffrey.l.hugo@...il.com>,
        "maz@...nel.org" <maz@...nel.org>,
        "Gupta, Puneet (DCG-ENG)" <puneet.gupta@....com>,
        "Michael.Srba@...nam.cz" <Michael.Srba@...nam.cz>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "will@...nel.org" <will@...nel.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "okaya@...nel.org" <okaya@...nel.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "song.bao.hua@...ilicon.com" <song.bao.hua@...ilicon.com>,
        "jgg@...dia.com" <jgg@...dia.com>,
        "mani@...nel.org" <mani@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Anand, Harpreet" <harpreet.anand@....com>,
        "yishaih@...dia.com" <yishaih@...dia.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "git (AMD-Xilinx)" <git@....com>,
        "saravanak@...gle.com" <saravanak@...gle.com>,
        "Radovanovic, Aleksandar" <aleksandar.radovanovic@....com>,
        "Simek, Michal" <michal.simek@....com>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
Subject: RE: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree
 bindings

[AMD Official Use Only - General]



> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Tuesday, September 6, 2022 11:17 PM
> To: Gupta, Nipun <Nipun.Gupta@....com>
> Cc: gregkh@...uxfoundation.org; eric.auger@...hat.com;
> devicetree@...r.kernel.org; linux-kbuild@...r.kernel.org;
> jeffrey.l.hugo@...il.com; maz@...nel.org; Gupta, Puneet (DCG-ENG)
> <puneet.gupta@....com>; Michael.Srba@...nam.cz; cohuck@...hat.com;
> will@...nel.org; masahiroy@...nel.org; mchehab+huawei@...nel.org;
> joro@...tes.org; okaya@...nel.org; alex.williamson@...hat.com;
> song.bao.hua@...ilicon.com; jgg@...dia.com; mani@...nel.org; linux-
> kernel@...r.kernel.org; robin.murphy@....com; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; rafael@...nel.org; f.fainelli@...il.com;
> jgg@...pe.ca; kvm@...r.kernel.org; Agarwal, Nikhil
> <nikhil.agarwal@....com>; Anand, Harpreet <harpreet.anand@....com>;
> yishaih@...dia.com; linux-arm-kernel@...ts.infradead.org; git (AMD-Xilinx)
> <git@....com>; saravanak@...gle.com; Radovanovic, Aleksandar
> <aleksandar.radovanovic@....com>; Simek, Michal
> <michal.simek@....com>; ndesaulniers@...gle.com
> Subject: Re: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree
> bindings
> 
> [CAUTION: External Email]
> 
> On Tue, 06 Sep 2022 19:17:55 +0530, Nipun Gupta wrote:
> > This patch adds a devicetree binding documentation for CDX
> > bus.
> >
> > CDX bus controller dynamically detects CDX bus and the
> > devices on these bus using CDX firmware.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> > ---
> >  .../devicetree/bindings/bus/xlnx,cdx.yaml     | 75 +++++++++++++++++++
> >  MAINTAINERS                                   |  6 ++
> >  2 files changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:18.23-21.11:
> Warning (unit_address_vs_reg): /example-0/smmu@...00000: node has a unit
> name, but no reg or ranges property
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:23.22-30.11:
> Warning (unit_address_vs_reg): /example-0/gic@...00000: node has a unit
> name, but no reg or ranges property
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:26.35-29.15:
> Warning (unit_address_vs_reg): /example-0/gic@...00000/gic-its@...40000:
> node has a unit name, but no reg or ranges property
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> smmu@...00000: $nodename:0: 'smmu@...00000' does not match
> '^iommu@[0-9a-f]*'
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> smmu@...00000: 'reg' is a required property
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: $nodename:0: 'gic@...00000' does not match '^interrupt-
> controller(@[0-9a-f,]+)*$'
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: '#interrupt-cells' is a dependency of 'interrupt-controller'
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: 'reg' is a required property
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: gic-its@...40000: False schema does not allow {'compatible':
> ['arm,gic-v3-its'], 'msi-controller': True, 'phandle': [[1]]}
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: gic-its@...40000: '#msi-cells' is a required property
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: gic-its@...40000: 'reg' is a required property
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@...00000: 'oneOf' conditional failed, one must be fixed:
>         'interrupts' is a required property
>         'interrupts-extended' is a required property
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> cdx@...0000: reg: [[0, 67108864], [0, 4096]] is too long
>         From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fpatch%2F&amp;data=05%7C01%7Cnipun.gupta%40amd.com
> %7C47f53d11f4024ba765f408da902fc525%7C3dd8961fe4884e608e11a82d994e
> 183d%7C0%7C0%7C637980832144301226%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&amp;sdata=BXO1d2OWdCQ1lb%2BEDNiUvmfSPPfxfzJET%2B
> uuAL9EdEY%3D&amp;reserved=0
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

I did run make dt_binding_check, but did not see the issue.
Will update the dtschema and fix this.

Thanks,
Nipun