linux-kernel - Re: Request to cherry-pick 01ea173e103edd5ec41acec65b9261b87e123fc2 to v5.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2022 10:46:19 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Varsha Teratipally <teratipally@...gle.com>
Cc:     "Darrick J. Wong" <djwong@...nel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: Request to cherry-pick 01ea173e103edd5ec41acec65b9261b87e123fc2
 to v5.10

On Tue, Sep 6, 2022 at 9:36 PM Varsha Teratipally
<teratipally@...gle.com> wrote:
>
> Hi all,
>
> Commit 01ea173e103edd5ec41acec65b9261b87e123fc2 (upstream: xfs: fix up
> non-directory creation in SGID directories) fixes an issue where in xfs
> sometimes, a local user could create files with an unitended group
> permissions as an owner and execution where a directory is SGID and belongs to a certain group and is writable by a user who is not a member of this group and seems like a good candidate for the v5.10 stable tree given that 5.10 is used in versions of debian, ubuntu.
>
> This patch applies cleanly. Let me know what you think
>

Since you already posted the patch, I wrote what I think on the post:

https://lore.kernel.org/linux-xfs/CAOQ4uxi_Q8aXUg+FM0Q9__t=KqJSVqOgkS8j8kNC3MQfniZLWA@mail.gmail.com/

Bottom line - I think that the patch should be applied to 5.10.y
without further delay.

Thanks,
Amir.