linux-kernel - Re: [PATCH] xfs: fix up non-directory creation in SGID directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxnWi5YcuY6Rbodt@kroah.com>
Date:   Thu, 8 Sep 2022 13:48:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Varsha Teratipally <teratipally@...gle.com>
Cc:     Amir Goldstein <amir73il@...il.com>,
        "Darrick J. Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH] xfs: fix up non-directory creation in SGID directories

On Tue, Sep 06, 2022 at 06:36:00PM +0000, Varsha Teratipally wrote:
> From: Christoph Hellwig <hch@....de>
> 
> XFS always inherits the SGID bit if it is set on the parent inode, while
> the generic inode_init_owner does not do this in a few cases where it can
> create a possible security problem, see commit 0fa3ecd87848
> ("Fix up non-directory creation in SGID directories") for details.
> 
> Switch XFS to use the generic helper for the normal path to fix this,
> just keeping the simple field inheritance open coded for the case of the
> non-sgid case with the bsdgrpid mount option.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Christian Brauner <christian.brauner@...ntu.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Darrick J. Wong <djwong@...nel.org>
> Signed-off-by: Darrick J. Wong <djwong@...nel.org>

Why did you not sign off on this if you are forwarding it on?

Also, what is the git id of this commit in Linus's tree (we need that
hint...)

Please fix both up and resend and get the ack of the stable xfs
developers on it as well.

thanks,

greg k-h