linux-kernel - Re: [v7 13/14] iio: imu: add BNO055 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdc8bAiqiUhEmgjNmcpY5s0fArTy26g2i0wH7srwY6RQA@mail.gmail.com>
Date:   Wed, 7 Sep 2022 17:09:26 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andrea Merello <andrea.merello@....it>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        jmondi <jacopo@...ndi.org>,
        Andrea Merello <andrea.merello@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver

On Wed, Sep 7, 2022 at 4:22 PM <andrea.merello@....it> wrote:
>
> From: Andrea Merello <andrea.merello@....it>
>
> Add an I2C driver for communicating to a BNO055 IMU via I2C bus and enable
> the BNO055 core driver to work in this scenario.
>
> Signed-off-by: Andrea Merello <andrea.merello@....it>

> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Hmm... It has my tag but I have noticed something to improve.

...

> +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */

Can we elaborate what to fix and why it can't be fixed right now?

...

> +static const struct of_device_id __maybe_unused bno055_i2c_of_match[] = {
> +       { .compatible = "bosch,bno055" },

> +       { },

No comma for the terminator entry.

> +};

...

> +               .of_match_table = of_match_ptr(bno055_i2c_of_match),

No of_match_ptr(). This will disable ACPI support along with potential
compiler warning.

-- 
With Best Regards,
Andy Shevchenko