linux-kernel - Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ea54f9b-896d-c70b-9024-4dc4f99ec2d4@acm.org>
Date:   Thu, 8 Sep 2022 15:30:27 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Asutosh Das <quic_asutoshd@...cinc.com>, quic_nguyenb@...cinc.com,
        quic_xiaosenh@...cinc.com, stanley.chu@...iatek.com,
        adrian.hunter@...el.com, avri.altman@....com, mani@...nel.org,
        quic_cang@...cinc.com, beanhuo@...ron.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support

On 9/2/22 15:41, Asutosh Das wrote:
> +static int ufs_qcom_get_hba_mac(struct ufs_hba *hba)
> +{
> +	return MAX_SUPP_MAC;
> +}

The above implementation is not sufficient to convince me that the 
get_hba_mac vop is useful. Please remove this vop and use MAX_SUPP_MAC 
directly where ufshcd_mcq_vops_get_hba_mac() is called.

Thanks,

Bart.