[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 9 Sep 2022 15:43:31 -0700
From: "Asutosh Das (asd)" <quic_asutoshd@...cinc.com>
To: Bart Van Assche <bvanassche@....org>, <quic_nguyenb@...cinc.com>,
<quic_xiaosenh@...cinc.com>, <stanley.chu@...iatek.com>,
<adrian.hunter@...el.com>, <avri.altman@....com>,
<mani@...nel.org>, <quic_cang@...cinc.com>, <beanhuo@...ron.com>,
<martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>
CC: <linux-arm-msm@...r.kernel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support
Hello Bart,
Thanks for taking a look.
On 9/8/2022 3:30 PM, Bart Van Assche wrote:
> On 9/2/22 15:41, Asutosh Das wrote:
>> +static int ufs_qcom_get_hba_mac(struct ufs_hba *hba)
>> +{
>> + return MAX_SUPP_MAC;
>> +}
>
> The above implementation is not sufficient to convince me that the
> get_hba_mac vop is useful. Please remove this vop and use MAX_SUPP_MAC
> directly where ufshcd_mcq_vops_get_hba_mac() is called.
>
The default value of MAC is 32 but it can have a max value of 256.
Here it has a value of 64.
So I think this vops would be helpful for other HC vendors as well who
may have a different value than the default.
> Thanks,
>
> Bart.
-asd
Powered by blists - more mailing lists