linux-kernel - Re: [PATCH] security/keys: Remove inconsistent _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxl6fJ/6c+KS9SsZ@kernel.org>
Date:   Thu, 8 Sep 2022 08:15:40 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>
Subject: Re: [PATCH] security/keys: Remove inconsistent __user annotation

On Wed, Sep 07, 2022 at 07:05:55AM -0700, Randy Dunlap wrote:
> 
> 
> On 9/7/22 05:12, Vincenzo Frascino wrote:
> > The declaration of keyring_read does not match the definition
> > (security/keys/keyring.c). In this case the definition is correct
> > because it matches what defined in "struct key_type::read"
> > (linux/key-type.h).
> > 
> > Fix the declaration removing the inconsistent __user annotation.
> > 
> > Cc: David Howells <dhowells@...hat.com>
> > Cc: Jarkko Sakkinen <jarkko@...nel.org>
> > Cc: Paul Moore <paul@...l-moore.com>
> > Cc: James Morris <jmorris@...ei.org>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> > ---
> > Note: This issue was discovered during the porting of the linux kernel
> > on Morello [1].
> > 
> > [1] https://git.morello-project.org/morello/kernel/linux
> 
> FTR, I have sent this same patch 3 times.
> Good luck.
> 
Right.

I'll pick this to my tree https://lore.kernel.org/keyrings/20220830191940.1498-1-rdunlap@infradead.org/

And need to clearly sync up better with David.

BR, Jarkko