linux-kernel - Re: [PATCH] security/keys: Remove inconsistent _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxl614jNUYvYywUc@kernel.org>
Date:   Thu, 8 Sep 2022 08:17:11 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Paul Moore <paul@...l-moore.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>
Subject: Re: [PATCH] security/keys: Remove inconsistent __user annotation

On Wed, Sep 07, 2022 at 11:43:17AM -0400, Paul Moore wrote:
> On Wed, Sep 7, 2022 at 10:06 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> > On 9/7/22 05:12, Vincenzo Frascino wrote:
> > > The declaration of keyring_read does not match the definition
> > > (security/keys/keyring.c). In this case the definition is correct
> > > because it matches what defined in "struct key_type::read"
> > > (linux/key-type.h).
> > >
> > > Fix the declaration removing the inconsistent __user annotation.
> > >
> > > Cc: David Howells <dhowells@...hat.com>
> > > Cc: Jarkko Sakkinen <jarkko@...nel.org>
> > > Cc: Paul Moore <paul@...l-moore.com>
> > > Cc: James Morris <jmorris@...ei.org>
> > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> > > ---
> > > Note: This issue was discovered during the porting of the linux kernel
> > > on Morello [1].
> > >
> > > [1] https://git.morello-project.org/morello/kernel/linux
> >
> > FTR, I have sent this same patch 3 times.
> > Good luck.
> 
> David or Jarkko, this patch is both trivial and obviously correct,
> please merge this into the keys tree for the next merge window else
> I'll take it via the LSM tree.
> 
> Reviewed-by: Paul Moore <paul@...l-moore.com>

I picked it to my tree.

BR, Jarkko