[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdb2dYvNkyx7O24uURjSYcCPkGR+Gj=weCSG6GdcM1B7Xw@mail.gmail.com>
Date: Thu, 8 Sep 2022 10:33:28 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
Mark Brown <broonie@...nel.org>,
Matti Vaittinen <mazziesaccount@...il.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Liam Girdwood <lgirdwood@...il.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Guenter Roeck <linux@...ck-us.net>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Felipe Balbi <balbi@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Krzysztof Wilczyński <kw@...ux.com>,
Vignesh Raghavendra <vigneshr@...com>,
Daniel Vetter <daniel@...ll.ch>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Marc Zyngier <maz@...nel.org>,
Richard Weinberger <richard@....at>,
David Airlie <airlied@...ux.ie>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Bartosz Golaszewski <brgl@...ev.pl>,
Jonathan Hunter <jonathanh@...dia.com>,
Rob Herring <robh@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Pali Rohár <pali@...nel.org>,
linux-watchdog@...r.kernel.org, linux-usb@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-pci@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index()
On Tue, Sep 6, 2022 at 2:19 AM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote:
> > I would like to stop exporting OF-specific gpiod_get_from_of_node()
> > so that gpiolib can be cleaned a bit, so let's switch to the generic
> > fwnode property API.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> >
> > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> > index a2c3c207a04b..d83817d3ff86 100644
> > --- a/drivers/pci/controller/pcie-apple.c
> > +++ b/drivers/pci/controller/pcie-apple.c
> > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
> > u32 stat, idx;
> > int ret, i;
> >
> > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0,
> > - GPIOD_OUT_LOW, "PERST#");
> > + reset = fwnode_gpiod_get_index(of_fwnode_handle(np),
> > + "reset", 0, GPIOD_OUT_LOW, "PERST#");
>
> Hmm, I am looking at the driver and it leaks the reset gpio on
> unbind/unload. I guess it does not matter in practice, but still nice
> not to leak. Thankfully it is easy to cure by switching to devm option:
> devm_fwnode_gpiod_get().
>
> I'll send and updated patch with a new justification.
With that change:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists