| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Sep 2022 20:32:38 +0800
From: kernel test robot <lkp@...el.com>
To: Anshuman Khandual <anshuman.khandual@....com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, peterz@...radead.org,
acme@...nel.org, mark.rutland@....com, will@...nel.org,
catalin.marinas@....com
Cc: kbuild-all@...ts.01.org,
Anshuman Khandual <anshuman.khandual@....com>,
James Clark <james.clark@....com>,
Rob Herring <robh@...nel.org>, Marc Zyngier <maz@...nel.org>,
Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE
Hi Anshuman,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on acme/perf/core]
[also build test WARNING on tip/perf/core arm64/for-next/core linus/master v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
base: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
config: arm-defconfig
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d3c4ba711027d312a2f4e16cdbdbec5fcbf2913b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
git checkout d3c4ba711027d312a2f4e16cdbdbec5fcbf2913b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/perf/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/perf/arm_pmu.c: In function 'validate_group':
>> drivers/perf/arm_pmu.c:415:1: warning: the frame size of 1744 bytes is larger than 1024 bytes [-Wframe-larger-than=]
415 | }
| ^
vim +415 drivers/perf/arm_pmu.c
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 387
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 388 static int
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 389 validate_group(struct perf_event *event)
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 390 {
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 391 struct perf_event *sibling, *leader = event->group_leader;
8be3f9a2385f91 arch/arm/kernel/perf_event.c Mark Rutland 2011-05-17 392 struct pmu_hw_events fake_pmu;
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 393
bce34d14428d35 arch/arm/kernel/perf_event.c Will Deacon 2011-11-17 394 /*
bce34d14428d35 arch/arm/kernel/perf_event.c Will Deacon 2011-11-17 395 * Initialise the fake PMU. We only need to populate the
bce34d14428d35 arch/arm/kernel/perf_event.c Will Deacon 2011-11-17 396 * used_mask for the purposes of validation.
bce34d14428d35 arch/arm/kernel/perf_event.c Will Deacon 2011-11-17 397 */
a4560846eba608 arch/arm/kernel/perf_event.c Mark Rutland 2014-05-13 398 memset(&fake_pmu.used_mask, 0, sizeof(fake_pmu.used_mask));
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 399
e429817b401f09 arch/arm/kernel/perf_event.c Suzuki K. Poulose 2015-03-17 400 if (!validate_event(event->pmu, &fake_pmu, leader))
aa2bc1ade59003 arch/arm/kernel/perf_event.c Peter Zijlstra 2011-11-09 401 return -EINVAL;
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 402
e5c23779f93d45 drivers/perf/arm_pmu.c Rob Herring 2022-04-08 403 if (event == leader)
e5c23779f93d45 drivers/perf/arm_pmu.c Rob Herring 2022-04-08 404 return 0;
e5c23779f93d45 drivers/perf/arm_pmu.c Rob Herring 2022-04-08 405
edb39592a5877b drivers/perf/arm_pmu.c Peter Zijlstra 2018-03-15 406 for_each_sibling_event(sibling, leader) {
e429817b401f09 arch/arm/kernel/perf_event.c Suzuki K. Poulose 2015-03-17 407 if (!validate_event(event->pmu, &fake_pmu, sibling))
aa2bc1ade59003 arch/arm/kernel/perf_event.c Peter Zijlstra 2011-11-09 408 return -EINVAL;
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 409 }
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 410
e429817b401f09 arch/arm/kernel/perf_event.c Suzuki K. Poulose 2015-03-17 411 if (!validate_event(event->pmu, &fake_pmu, event))
aa2bc1ade59003 arch/arm/kernel/perf_event.c Peter Zijlstra 2011-11-09 412 return -EINVAL;
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 413
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 414 return 0;
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 @415 }
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 416
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (260272 bytes)
Powered by blists - more mailing lists