Date:   Thu, 8 Sep 2022 22:14:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, peterz@...radead.org,
        acme@...nel.org, mark.rutland@....com, will@...nel.org,
        catalin.marinas@....com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Anshuman Khandual <anshuman.khandual@....com>,
        James Clark <james.clark@....com>,
        Rob Herring <robh@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE

Hi Anshuman,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on acme/perf/core]
[also build test WARNING on tip/perf/core arm64/for-next/core linus/master v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
config: arm-spitz_defconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/d3c4ba711027d312a2f4e16cdbdbec5fcbf2913b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
        git checkout d3c4ba711027d312a2f4e16cdbdbec5fcbf2913b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/perf/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/perf/arm_pmu.c:498:12: warning: stack frame size (1760) exceeds limit (1024) in 'armpmu_event_init' [-Wframe-larger-than]
   static int armpmu_event_init(struct perf_event *event)
              ^
   1 warning generated.


vim +/armpmu_event_init +498 drivers/perf/arm_pmu.c

1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles       2010-02-02  497  
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra   2010-06-11 @498  static int armpmu_event_init(struct perf_event *event)
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles       2010-02-02  499  {
8a16b34e21199e arch/arm/kernel/perf_event.c Mark Rutland     2011-04-28  500  	struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles       2010-02-02  501  
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  502  	/*
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  503  	 * Reject CPU-affine events for CPUs that are of a different class to
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  504  	 * that which this PMU handles. Process-following events (where
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  505  	 * event->cpu == -1) can be migrated between CPUs, and thus we have to
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  506  	 * reject them later (in armpmu_add) if they're scheduled on a
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  507  	 * different class of CPU.
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  508  	 */
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  509  	if (event->cpu != -1 &&
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  510  		!cpumask_test_cpu(event->cpu, &armpmu->supported_cpus))
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  511  		return -ENOENT;
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland     2015-05-13  512  
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09  513  	/* does not support taken branch sampling */
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09  514  	if (has_branch_stack(event))
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09  515  		return -EOPNOTSUPP;
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09  516  
e1f431b57ef9e4 arch/arm/kernel/perf_event.c Mark Rutland     2011-04-28  517  	if (armpmu->map_event(event) == -ENOENT)
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra   2010-06-11  518  		return -ENOENT;
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra   2010-06-11  519  
c09adab01e4aee drivers/perf/arm_pmu.c       Mark Rutland     2017-03-10  520  	return __hw_perf_event_init(event);
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles       2010-02-02  521  }
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles       2010-02-02  522  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (97926 bytes)

Powered by blists - more mailing lists