linux-kernel - Re: [PATCH v1 1/1] spi: Group cs_change and cs_off flags together in struct spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yxnn+Puts9Bv2f+a@smile.fi.intel.com>
Date:   Thu, 8 Sep 2022 16:02:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] spi: Group cs_change and cs_off flags together in
 struct spi_transfer

On Thu, Sep 08, 2022 at 03:54:44PM +0300, Andy Shevchenko wrote:
> The commit 5e0531f6b90a ("spi: Add capability to perform some transfer
> with chipselect off") added a new flag but squezed it into a wrong
> group of struct spi_transfer members (note that SPI_NBITS_* are macros
> for easier interpretation of the tx_nbits and rx_nbits bitfields.

Besides some small issues with the grammar above, I would like also to
reshuffle the documentation part. Hence, please wait for v2 of this.

-- 
With Best Regards,
Andy Shevchenko