linux-kernel - [PATCH] net: broadcom: bcm4908enet: add platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  9 Sep 2022 14:25:45 +0800
From:   Yu Zhe <yuzhe@...china.com>
To:     rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, liqiong@...china.com,
        Yu Zhe <yuzhe@...china.com>
Subject: [PATCH] net: broadcom: bcm4908enet: add platform_get_irq_byname error checking

The platform_get_irq_byname() function returns negative error codes on error,
check it.

Signed-off-by: Yu Zhe <yuzhe@...china.com>
---
 drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
index c131d8118489..d985056db6c2 100644
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
@@ -705,6 +705,8 @@ static int bcm4908_enet_probe(struct platform_device *pdev)
 		return netdev->irq;
 
 	enet->irq_tx = platform_get_irq_byname(pdev, "tx");
+	if (enet->irq_tx < 0)
+		return enet->irq_tx;
 
 	err = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
 	if (err)
-- 
2.11.0