[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 9 Sep 2022 10:02:51 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Patrick Rudolph <patrick.rudolph@...ements.com>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all
switch-cases (part 2)
On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> Move the default values to the 'default' case in the switches.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Patch applied!
> case CY8C95X0_DRV_PP_SLOW:
> case CY8C95X0_DRV_HIZ:
> return true;
> + default:
> + return false;
> }
> -
> - return false;
> }
Clearly this is better style, I wonder if we could teach checkpatch to
look for this? Or cocinelle?
Yours,
Linus Walleij
Powered by blists - more mailing lists