linux-kernel - Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 11:42:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Patrick Rudolph <patrick.rudolph@...ements.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all
 switch-cases (part 2)

On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > Move the default values to the 'default' case in the switches.

> Patch applied!

Thanks!

...

> >         case CY8C95X0_DRV_PP_SLOW:
> >         case CY8C95X0_DRV_HIZ:
> >                 return true;
> > +       default:
> > +               return false;
> >         }
> > -
> > -       return false;
> 
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?

The latter I believe. But I'm too busy and too lazy to go that road.

-- 
With Best Regards,
Andy Shevchenko