[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Sep 2022 20:36:44 -0500
From: Rob Herring <robh@...nel.org>
To: Sergiu.Moga@...rochip.com
Cc: krzysztof.kozlowski@...aro.org, lee@...nel.org,
krzysztof.kozlowski+dt@...aro.org, Nicolas.Ferre@...rochip.com,
alexandre.belloni@...tlin.com, Claudiu.Beznea@...rochip.com,
richard.genoud@...il.com, radu_nicolae.pirea@....ro,
gregkh@...uxfoundation.org, broonie@...nel.org,
mturquette@...libre.com, sboyd@...nel.org, jirislaby@...nel.org,
admin@...iphile.com, Kavyasree.Kotagiri@...rochip.com,
Tudor.Ambarus@...rochip.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-spi@...r.kernel.org, linux-serial@...r.kernel.org,
linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add
SAM9260 compatibles to SAM9x60
On Thu, Sep 08, 2022 at 03:15:44PM +0000, Sergiu.Moga@...rochip.com wrote:
> On 08.09.2022 15:30, Krzysztof Kozlowski wrote:
> > On 06/09/2022 15:55, Sergiu Moga wrote:
> >> Add the AT91SAM9260 serial compatibles to the list of SAM9X60 compatibles
> >> in order to highlight the incremental characteristics of the SAM9X60
> >> serial IP.
> >>
> >> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
> >> ---
> >>
> >>
> >> v1 -> v2:
> >> - Nothing, this patch was not here before
> >>
> >>
> >> Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> index b25535b7a4d2..4d80006963c7 100644
> >> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> @@ -26,6 +26,8 @@ properties:
> >> - items:
> >> - const: microchip,sam9x60-dbgu
> >> - const: microchip,sam9x60-usart
> >> + - const: atmel,at91sam9260-dbgu
> >> + - const: atmel,at91sam9260-usart
> >
> > This is weird. You say in commit msg to "highlight the incremental
> > characteristics" but you basically change here existing compatibles.
>
>
> Does "show that they are incremental IP's" sound better then?
>
>
> > This is not enum, but a list.
> >
>
>
> What do you mean by this? I know it is a list, I specified so in the
> commit message.
You are saying that compatible must be exactly the 4 strings above in
the order listed. You need another entry with another 'items' list.
Rob
Powered by blists - more mailing lists