[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 9 Sep 2022 10:46:00 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: James Clark <james.clark@....com>
Cc: Gaosheng Cui <cuigaosheng1@...wei.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
namhyung@...nel.org, atrajeev@...ux.vnet.ibm.com,
eranian@...gle.com
Subject: Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> >
> >
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> >
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
>
> Yeah, indeed, unsure if at that time the declaration was needed.
>
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
>
> Ditto here, I'll remove the reference and rewrite the cset log a bit.
I left it as:
perf pmu: Remove perf_pmu_lex() needless declaration
It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.
Powered by blists - more mailing lists