linux-kernel - Re: [PATCH v3 8/8] sched/fair: Add latency list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Sep 2022 14:32:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
        juri.lelli@...hat.com, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org, parth@...ux.ibm.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org, qais.yousef@....com,
        chris.hyser@...cle.com, valentin.schneider@....com,
        patrick.bellasi@...bug.net, David.Laight@...lab.com,
        pjt@...gle.com, pavel@....cz, tj@...nel.org, qperret@...gle.com,
        tim.c.chen@...ux.intel.com, joshdon@...gle.com,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH v3 8/8] sched/fair: Add latency list

Hi Vincent,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git fb04563d1cae6f361892b4a339ad92100b1eb0d0
config: hexagon-randconfig-r041-20220907
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4bdc6637b9aab44577b65686a745a14b325f4c23
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
        git checkout 4bdc6637b9aab44577b65686a745a14b325f4c23
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/sched/fair.c:727:22: warning: no previous prototype for function '__pick_first_latency' [-Wmissing-prototypes]
   struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
                        ^
   kernel/sched/fair.c:727:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
   ^
   static 
   kernel/sched/fair.c:519:20: warning: unused function 'list_del_leaf_cfs_rq' [-Wunused-function]
   static inline void list_del_leaf_cfs_rq(struct cfs_rq *cfs_rq)
                      ^
   kernel/sched/fair.c:540:19: warning: unused function 'tg_is_idle' [-Wunused-function]
   static inline int tg_is_idle(struct task_group *tg)
                     ^
   kernel/sched/fair.c:3414:20: warning: unused function 'load_avg_is_decayed' [-Wunused-function]
   static inline bool load_avg_is_decayed(struct sched_avg *sa)
                      ^
   kernel/sched/fair.c:5683:20: warning: unused function 'cfs_bandwidth_used' [-Wunused-function]
   static inline bool cfs_bandwidth_used(void)
                      ^
   kernel/sched/fair.c:5691:20: warning: unused function 'sync_throttle' [-Wunused-function]
   static inline void sync_throttle(struct task_group *tg, int cpu) {}
                      ^
   kernel/sched/fair.c:5716:37: warning: unused function 'tg_cfs_bandwidth' [-Wunused-function]
   static inline struct cfs_bandwidth *tg_cfs_bandwidth(struct task_group *tg)
                                       ^
   kernel/sched/fair.c:5720:20: warning: unused function 'destroy_cfs_bandwidth' [-Wunused-function]
   static inline void destroy_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
                      ^
   kernel/sched/fair.c:8719:19: warning: unused function 'check_misfit_status' [-Wunused-function]
   static inline int check_misfit_status(struct rq *rq, struct sched_domain *sd)
                     ^
   9 warnings generated.


vim +/__pick_first_latency +727 kernel/sched/fair.c

   726	
 > 727	struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
   728	{
   729		struct rb_node *left = rb_first_cached(&cfs_rq->latency_timeline);
   730	
   731		if (!left)
   732			return NULL;
   733	
   734		return __latency_node_2_se(left);
   735	}
   736	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (114620 bytes)