linux-kernel - Re: [PATCH v3 5/8] sched/fair: Take into account latency priority at wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202209101449.svisloe1-lkp@intel.com>
Date:   Sat, 10 Sep 2022 14:32:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org, parth@...ux.ibm.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org, qais.yousef@....com,
        chris.hyser@...cle.com, valentin.schneider@....com,
        patrick.bellasi@...bug.net, David.Laight@...lab.com,
        pjt@...gle.com, pavel@....cz, tj@...nel.org, qperret@...gle.com,
        tim.c.chen@...ux.intel.com, joshdon@...gle.com,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH v3 5/8] sched/fair: Take into account latency priority at
 wakeup

Hi Vincent,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git fb04563d1cae6f361892b4a339ad92100b1eb0d0
config: riscv-randconfig-r042-20220907
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/afc6aa506d9f5f0d666b28d01f39e542301618eb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
        git checkout afc6aa506d9f5f0d666b28d01f39e542301618eb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> kernel/sched/core.c:1295:26: error: use of undeclared identifier 'sysctl_sched_latency'; did you mean 'sysctl_sched_features'?
           p->se.latency_offset = (sysctl_sched_latency * weight) >> NICE_LATENCY_SHIFT;
                                   ^~~~~~~~~~~~~~~~~~~~
                                   sysctl_sched_features
   kernel/sched/sched.h:2053:48: note: 'sysctl_sched_features' declared here
   static const_debug __maybe_unused unsigned int sysctl_sched_features =
                                                  ^
   kernel/sched/core.c:6615:35: warning: no previous prototype for function 'schedule_user' [-Wmissing-prototypes]
   asmlinkage __visible void __sched schedule_user(void)
                                     ^
   kernel/sched/core.c:6615:22: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage __visible void __sched schedule_user(void)
                        ^
                        static 
   1 warning and 1 error generated.


vim +1295 kernel/sched/core.c

  1290	
  1291	static void set_latency_offset(struct task_struct *p)
  1292	{
  1293		long weight = sched_latency_to_weight[p->latency_prio];
  1294	
> 1295		p->se.latency_offset = (sysctl_sched_latency * weight) >> NICE_LATENCY_SHIFT;
  1296	}
  1297	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (175061 bytes)