[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6f2ec41a-a6fa-dce7-66ee-e9ac3d3ab6f5@linaro.org>
Date: Sun, 11 Sep 2022 12:26:01 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Iskren Chernev <iskren.chernev@...il.com>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/9] arm64: dts: qcom: sm6115: Add basic soc dtsi
On 11/09/2022 12:22, Iskren Chernev wrote:
> basic-state { // this matches the first state in oneOf
> pins: "gpio1";
> funciton: "normal";
> };
>
> nested-state {
> some-pins { // this matches the second state in oneOf
> pins: "gpio1";
> funciton: "normal";
> };
> other-pins {
> pins: "gpio2"
> funciton: "normal";
> };
> }
>
> // but also, matching second state in oneOf
> nested-basic-state {
> pinconf {
> pins: "gpio1";
> funciton: "normal";
> };
> };
> };
>
> So I'm saying, we should either choose basic-state and nested-state, in which
> case we don't need the "^pinconf$" variant, or we can have nested-state and
> nested-basic-state, in which case we don't need the 1st case of the oneOf.
Ah, I get it.
>
> Otherwise people have to choose between basic-state and nested-basic-state,
> which are equivalent in semantics.
Yeah, I can drop pinconf. I put it in the PMIC because it was used, but
I don't find it for TLMM pinctrl nodes.
>
> On a tangent -- why specifying the .* regex of pinctrl subnodes has effect on
> pinctrl references in other nodes. I.e I don't understand why this fix fixes
> the issue (but it does).
Because it works on DTB and finds linux,phandle. This might be some bug
in dtschema, but anyway better to have a bit stricter patterns in bindings.
Best regards,
Krzysztof
Powered by blists - more mailing lists