linux-kernel - Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220911105215.72bd79f3@jic23-huawei>
Date:   Sun, 11 Sep 2022 10:52:15 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics

On Tue, 6 Sep 2022 16:36:20 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Mon, Jun 20, 2022 at 08:42:25PM +0100, Jonathan Cameron wrote:
> > On Fri, 3 Jun 2022 18:10:06 +0100
> > Jonathan Cameron <jic23@...nel.org> wrote:  
> > > On Mon, 30 May 2022 20:33:24 +0300
> > > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > >   
> > > > First of all, the additional conversion from vIRQ, and this is exactly
> > > > what is returned by platform_get_irq_byname(), to vIRQ is not needed.    
> > > Confusing sentence form.  Perhaps:
> > > 
> > > First, the additional conversion from vIRQ (returned by platform_get_irq_byname())
> > > to vIRQ is not needed.
> > >   
> > > > Hence, drop no-op call to irq_of_parse_and_map().
> > > > 
> > > > Second, assign the firmware node instead of of_node.  
> 
> ...
> 
> > > Seems sensible to me, but I'd like a sanity check from someone more
> > > familiar with this driver.  
> > 
> > This one has been outstanding for a few weeks. I'd still like
> > an Ack or similar form someone who knows this device well.
> > 
> > If no one has looked at it in a week or so I'll just go with
> > my judgement and pick it up.  
> 
> Any news on this one? Maybe I need to resend with the better commit message?
> 

From glancing back at the thread, looks like you said you were going to send
a v2 with property.h include.  I think the rest of the thread is concerned
with a different issue entirely.

Jonathan