linux-kernel - Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2febb7893346b6234983453de7c037536e479bfc.camel@perches.com>
Date:   Sat, 10 Sep 2022 19:47:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     "niklas.soderlund@...igine.com" <niklas.soderlund@...igine.com>,
        Philippe Schenker <philippe.schenker@...adex.com>
Cc:     "corbet@....net" <corbet@....net>,
        "dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
        "apw@...onical.com" <apw@...onical.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "louis.peens@...igine.com" <louis.peens@...igine.com>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>
Subject: Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style

On Fri, 2022-09-09 at 10:57 -0700, Joe Perches wrote:
> On Fri, 2022-09-09 at 09:40 +0200, niklas.soderlund@...igine.com wrote:
> > On 2022-09-08 17:49:14 +0000, Philippe Schenker wrote:
[]
> > > I would check all lines that start with fixes, even if there is
> > > whitespace in front (and then failing later on...)
> > > 
> > > if (!$in_header_lines && $line =~ /^\s*fixes:?/i) {
> 
> I think that's a poor idea.
> 
> You should really review git history for lines that start with fixes
> and look at the number of false positives that would give.
> 
> Try this grep:
> 
> $ git log -100000 --no-merges --grep="^\s*fixes" -i --format=email -P | \
>   grep -P -i "^\s*fixes)" | \
>   grep -P -v "^Fixes: [0-9a-f]{12,}'
> [...]
> 
> That is a greater than 10% false positive rate.

One day I'll be better at typing grep commands in the editor...

Try:

$ git log -100000 --no-merges --grep="^\s*fixes" -i --format=email -P | \
  grep -P -i "^\s*fixes" | \
  grep -P -v "^Fixes: [0-9a-f]{12,}"