linux-kernel - Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Sep 2022 10:48:58 +0200
From:   "niklas.soderlund@...igine.com" <niklas.soderlund@...igine.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Philippe Schenker <philippe.schenker@...adex.com>,
        "corbet@....net" <corbet@....net>,
        "dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
        "apw@...onical.com" <apw@...onical.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "louis.peens@...igine.com" <louis.peens@...igine.com>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>
Subject: Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style

Hi Joe,

Thanks for your feedback.

On 2022-09-09 10:57:10 -0700, Joe Perches wrote:
> I think it's better to make sure that there is a likely SHA1 of some
> minimum length after the fixes line.
> 
> And a relatively common defect is to have the word "commit" after fixes.
> 
> e.g.:
> 
> Fixes commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
> Fixes commit a2c60d42d97c ("Add files for new driver - part 16").
> 
> So maybe:
> 
> 	if (!$in_header_lines &&
> 	    $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i)

I'm sorry I just sent out v6 and missed this comment, which I think is a 
great idea. I will let v6 stew for a day or two in case there is other 
feedback and then spin a v7 with this addressed.

-- 
Kind Regards,
Niklas Söderlund