linux-kernel - RE: [RESEND PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 12 Sep 2022 08:16:16 +0000
From:   <Kavyasree.Kotagiri@...rochip.com>
To:     <robh@...nel.org>
CC:     <Claudiu.Beznea@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <krzysztof.kozlowski+dt@...aro.org>, <Nicolas.Ferre@...rochip.com>,
        <lee@...nel.org>, <robh+dt@...nel.org>, <Sergiu.Moga@...rochip.com>
Subject: RE: [RESEND PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to
 json-schema

> > > Convert the Atmel flexcom device tree bindings to json schema.
> > >
> > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> > > ---
> > > v8 -> v9:
> > >  - Changed reference provided for spi bindings to atmel,at91rm9200-
> > spi.yaml
> > >
> > > v7 -> v8:
> > >  - Added back patternProperties for child nodes.
> > >
> > > v6 -> v7:
> > >  - Change filename to atmel,sama5d2-flexcom.yaml
> > >  - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> > >
> > > v5 -> v6:
> > >  - Removed spi node from example as suggested by Rob and
> > >    also pattern properties(spi dt-bindings conversion to yaml patch is
> under
> > review).
> > >    Once that is accepted, I will add back spi example through new patch.
> > >
> > > v4 -> v5:
> > >  - Fixed indentations.
> > >
> > > v3 -> v4:
> > >  - Corrected format of enum used for compatible string.
> > >
> > > v2 -> v3:
> > >  - used enum for compatible string.
> > >  - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > >  - fixed dtschema errors.
> > >
> > > v1 -> v2:
> > >  - Fix title.
> > >
> > >  .../bindings/mfd/atmel,sama5d2-flexcom.yaml   | 91
> > +++++++++++++++++++
> > >  .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 -------------
> > >  2 files changed, 91 insertions(+), 63 deletions(-)
> > >  create mode 100644
> > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > flexcom.txt
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/
> >
> >
> > flexcom@...40000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> >         arch/arm/boot/dts/lan966x-pcb8291.dtb
> >         arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@...44000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> >         arch/arm/boot/dts/lan966x-pcb8291.dtb
> >         arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@...60000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> >         arch/arm/boot/dts/lan966x-pcb8291.dtb
> >         arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@...64000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> >         arch/arm/boot/dts/lan966x-pcb8291.dtb
> >         arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@...70000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> >         arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> >         arch/arm/boot/dts/lan966x-pcb8291.dtb
> >         arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@...24000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-sama7g5ek.dtb
> >
> > flexcom@...34000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-kizbox3-hs.dtb
> >         arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_icp.dtb
> >         arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@...38000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-kizbox3-hs.dtb
> >         arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_icp.dtb
> >         arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@...10000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-kizbox3-hs.dtb
> >         arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_icp.dtb
> >         arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@...14000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-kizbox3-hs.dtb
> >         arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_icp.dtb
> >         arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@...18000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> >         arch/arm/boot/dts/at91-kizbox3-hs.dtb
> >         arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_icp.dtb
> >         arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> >         arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> 
> dma properties for spi node is already being covered by Sergiu in below
> patch:
> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854-
> 751a48545576@...aro.org/
> 
Hi Rob, Please let me know your comments.

Thanks,
Kavya

> 
> Thanks,
> Kavya