linux-kernel - Re: [PATCH] iio: ltc2497: Fix reading conversion results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220912104631.zysrv2qqxvsjfbxc@pengutronix.de>
Date:   Mon, 12 Sep 2022 12:46:31 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Denys Zagorui <dzagorui@...co.com>, Meng.Li@...driver.com,
        lars@...afoo.de, Michael.Hennerich@...log.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: ltc2497: Fix reading conversion results

On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote:
> On Mon, 15 Aug 2022 09:16:47 +0000
> Denys Zagorui <dzagorui@...co.com> wrote:
> 
> > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > After the result of the previous conversion is read the chip
> > automatically starts a new conversion and doesn't accept new i2c
> > transfers until this conversion is completed which makes the function
> > return failure.
> 
> That's rather nasty.
> 
> Could we add a cheeky sleep in the other path to ensure there is always
> time for the conversion to be done?  Not ideal, but might ensure
> there isn't a known problem path without introducing much complexity.

FTR: While the patch was originally authored by me, I don't currently
have access to a machine with that chip. So currently there will be no
incentive on my side to address this feedback.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)