linux-kernel - Re: [PATCH] iio: ltc2497: Fix reading conversion results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220918152224.14f874c1@jic23-huawei>
Date:   Sun, 18 Sep 2022 15:22:24 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Denys Zagorui <dzagorui@...co.com>, Meng.Li@...driver.com,
        lars@...afoo.de, Michael.Hennerich@...log.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: ltc2497: Fix reading conversion results

On Mon, 12 Sep 2022 12:46:31 +0200
Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:

> On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote:
> > On Mon, 15 Aug 2022 09:16:47 +0000
> > Denys Zagorui <dzagorui@...co.com> wrote:
> >   
> > > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > 
> > > After the result of the previous conversion is read the chip
> > > automatically starts a new conversion and doesn't accept new i2c
> > > transfers until this conversion is completed which makes the function
> > > return failure.  
> > 
> > That's rather nasty.
> > 
> > Could we add a cheeky sleep in the other path to ensure there is always
> > time for the conversion to be done?  Not ideal, but might ensure
> > there isn't a known problem path without introducing much complexity.  
> 
> FTR: While the patch was originally authored by me, I don't currently
> have access to a machine with that chip. So currently there will be no
> incentive on my side to address this feedback.

I'm not keen to keep changes to this driver queued up on improving this patch.
Hence applied to the togreg branch of iio.git and I'll push that out as testing
shortly for the autobuilders to poke at it.

I have also marked it for stable.

Thanks,

Jonathan

> 
> Best regards
> Uwe
>