linux-kernel - Re: [PATCH linux-next] smack: lsm: remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48dd3c0e-f652-798f-9cb9-a53aaae6dcb9@schaufler-ca.com>
Date:   Mon, 12 Sep 2022 10:00:04 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     cgel.zte@...il.com
Cc:     paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xu Panda <xu.panda@....com.cn>,
        Zeal Robot <zealci@....com.cn>, casey@...aufler-ca.com
Subject: Re: [PATCH linux-next] smack: lsm: remove the unneeded result
 variable

On 9/12/2022 3:05 AM, cgel.zte@...il.com wrote:
> From: Xu Panda <xu.panda@....com.cn>
>
> Return the value smk_ptrace_rule_check() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>

Added to https://github.com/cschaufler/smack-next#next.
Thank you.

> ---
>  security/smack/smack_lsm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 16e24a6cdc7c..b6306d71c908 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
>   */
>  static int smack_ptrace_traceme(struct task_struct *ptp)
>  {
> -       int rc;
>         struct smack_known *skp;
>
>         skp = smk_of_task(smack_cred(current_cred()));
>
> -       rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
> -       return rc;
> +       return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
>  }
>
>  /**