linux-kernel - Re: [PATCH] fs/netfs3: add a boundary check for EA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2022 14:16:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     eadavis@...a.com,
        syzbot+c4d950787fd5553287b7@...kaller.appspotmail.com
Cc:     kbuild-all@...ts.01.org, almaz.alexandrovich@...agon-software.com,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        nathan@...nel.org, ndesaulniers@...gle.com, ntfs3@...ts.linux.dev,
        syzkaller-bugs@...glegroups.com, trix@...hat.com,
        Edward Adam Davis <eadvis@...a.com>
Subject: Re: [PATCH] fs/netfs3: add a boundary check for EA_FULL

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc5 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/eadavis-sina-com/fs-netfs3-add-a-boundary-check-for-EA_FULL/20220912-114458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 80e78fcce86de0288793a0ef0f6acf37656ee4cf
config: sparc-randconfig-r024-20220911
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2d169c3ed66886da971be5f3c6c24137ee7877d6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review eadavis-sina-com/fs-netfs3-add-a-boundary-check-for-EA_FULL/20220912-114458
        git checkout 2d169c3ed66886da971be5f3c6c24137ee7877d6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash fs/ntfs3/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   fs/ntfs3/xattr.c: In function 'find_ea':
>> fs/ntfs3/xattr.c:1108:19: error: unterminated argument list invoking macro "if"
    1108 | // clang-format on
         |                   ^
>> fs/ntfs3/xattr.c:1109: error: expected '(' at end of input
   fs/ntfs3/xattr.c:69:17: note: '-Wmisleading-indentation' is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers
      69 |                 if (next_len >= bytes ||
         |                 ^~
   fs/ntfs3/xattr.c:69:17: note: adding '-flarge-source-files' will allow for more column-tracking support, at the expense of compilation time and memory
>> fs/ntfs3/xattr.c:69:17: error: expected declaration or statement at end of input
>> fs/ntfs3/xattr.c:55:21: warning: variable 'next_len' set but not used [-Wunused-but-set-variable]
      55 |                 u32 next_len = 0;
         |                     ^~~~~~~~
>> fs/ntfs3/xattr.c:69:17: error: expected declaration or statement at end of input
      69 |                 if (next_len >= bytes ||
         |                 ^~


vim +/if +1108 fs/ntfs3/xattr.c

be71b5cba2e648 Konstantin Komarov 2021-08-13  1103  
be71b5cba2e648 Konstantin Komarov 2021-08-13  1104  const struct xattr_handler *ntfs_xattr_handlers[] = {
be71b5cba2e648 Konstantin Komarov 2021-08-13  1105  	&ntfs_xattr_handler,
be71b5cba2e648 Konstantin Komarov 2021-08-13  1106  	NULL,
be71b5cba2e648 Konstantin Komarov 2021-08-13  1107  };
be71b5cba2e648 Konstantin Komarov 2021-08-13 @1108  // clang-format on

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (129791 bytes)